D21897: Address some issues reported by Krazy analysis

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in krichtextwidget.cpp:638
> This should be `linkDialog && linkDialog->exec()`

This is unusual, but it's the right way around. The point of this is to check if the dialog has been deleted during the sub-eventloop behind exec(). No idea if that can happen here though, but that's generally the idea behind this pattern.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21897

To: pajamapants3000, elvisangelaccio
Cc: vkrause, elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190825/7b1a7e57/attachment.html>