D23420: Use solid to check if a a KFileItem is located on a network mount

Anthony Fieroni noreply at phabricator.kde.org
Sun Aug 25 09:46:35 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileitem.cpp:767-771
> +                m_slow = Slow;
> +                break;
> +            }
>          }
> +        m_slow = Fast;

Wrong logic, when you set it to Slow, after break it will go to line 771 and became Fast again. Set it Fast before loop or check whether you change the m_slow value.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190825/86b5b405/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list