D23411: Fix crash in writer collection and cleanup

Alexander Stippich noreply at phabricator.kde.org
Sat Aug 24 21:24:13 BST 2019


astippich created this revision.
astippich added reviewers: bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  WriterCollection was apparently never used.
  It crashed upon destruction due to bogus
  deletion of the writer plugins.
  This carries over some code of the 
  ExtractorCollection and cleans up a little
  bit along the way. Adds a simple test.

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixWriterCollection

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190824/23b0f5f5/attachment.html>


More information about the Kde-frameworks-devel mailing list