D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Hmm I see this is only about the (few) entries in the Places view, not about general navigation into subsubdirs. So my initial comment was a bit nonsense.

INLINE COMMENTS

> anthonyfieroni wrote in kfileplacesview.cpp:256
> You will get the job as lambda parameter.

Yes but he needs it for !info.job 3 lines above, to avoid starting multiple jobs for the same thing at the same time.

> kfileplacesview.cpp:263
> +
> +                    if (job->error() != KIO::Job::NoError) {
> +                        return;

Usually written as

  if (job->error())

> davidedmundson wrote in kfileplacesview.cpp:1089
> I think David F means you should connect here and expunge dead entries.

and clear the map in this method.

But I see that calling setModel twice isn't really supported properly anyway (no disconnects).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

To: broulik, #frameworks, dfaure, lbeltrame
Cc: davidedmundson, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190824/b9e39d6c/attachment-0001.html>