D23119: Fix dates being on the wrong locale when setting an application language individually

Alexander Semke noreply at phabricator.kde.org
Fri Aug 23 10:22:05 BST 2019


asemke added inline comments.

INLINE COMMENTS

> asemke wrote in kxmlgui_unittest.cpp:1089
> This is maybe not Qt but the locale defintion files which are probably distro specific. I just checked on SLES and on openSuse.
> 
> for ukrainian:
> 
>   LC_TIME=uk_UA.UTF-8 locale mon
>   січень;лютий;березень;квітень;травень;червень;липень;серпень;вересень;жовтень;листопад;грудень
> 
> for russian:
> 
>   LC_TIME=ru_RU.UTF-8 locale mon
>   Январь;Февраль;Март;Апрель;Май;Июнь;Июль;Август;Сентябрь;Октябрь;Ноябрь;Декабрь
> 
> This is, except of capital letters for ru_RU, correct.
> 
> On Mac I get however
> 
>   січня;лютого;березня;квітня;травня;червня;липня;серпня;вересня;жовтня;листопада;грудня
> 
> and
> 
>   января;февраля;марта;апреля;мая;июня;июля;августа;сентября;октября;ноября;декабря
> 
> which is possessive case and is wrong if you reffer to the name of the month itself.
> 
> @aacid on your distribution you'll most probably get the same output as on my Mac. Under the assumption that Qt evaluates the locale definition files, your test will probably fail on other distributions which do this correctly.

@aacid the discussion about declensions in slawic languages is not relevant to your patch I'd say. Maybe it's better to use in the test a language like German or any other languages where we don't have this additional complication.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190823/b38aa688/attachment.html>


More information about the Kde-frameworks-devel mailing list