D23373: KTextEditor: Fix left border flicker when switching between documents

Daan De Meyer noreply at phabricator.kde.org
Fri Aug 23 10:05:47 BST 2019


daandemeyer created this revision.
daandemeyer added a reviewer: KTextEditor.
daandemeyer added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this revision.

REVISION SUMMARY
  See https://mail.kde.org/pipermail/kwrite-devel/2019-August/005302.html
  
  Because the ` Qt::WA_OpaquePaintEvent ` was not enabled, Qt was erasing the widget's area before repainting which briefly cause the background to appear which caused flickering when switching between documents. We can simply enable the `Qt::WA_OpaquePaintEvent ` option which tells Qt to not erase the widget's area before repainting. This fixes the flickering when switching between documents.
  
  This does assume the icon bar does not rely on the widget background color which is the case in my scenario but hopefully one of the maintainers can confirm that this is always the case.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23373

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: daandemeyer, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, LeGast00n, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190823/95d0d629/attachment.html>


More information about the Kde-frameworks-devel mailing list