D23119: Fix dates being on the wrong locale when setting an application language individually

Alexander Semke noreply at phabricator.kde.org
Fri Aug 23 08:14:52 BST 2019


asemke added inline comments.

INLINE COMMENTS

> ltoscano wrote in kxmlgui_unittest.cpp:1089
> Declensions: https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension

there is no declension in Russian for the nominative case. The name of the month is январь and not января, but it is первого января (on January 1st) and not первого январь.

https://doc.qt.io/qt-5/qlocale.html#monthName - QLocale must return the name of the month, meaning the nominative case  and not one of its declensions.

> aacid wrote in kxmlgui_unittest.cpp:1089
> Yes, it may surprise you, but i did actually run the tests before submitting this code change.

The question was rethoric. I was rather surprised about the validnes of the check you did here.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190823/f766fa1e/attachment.html>


More information about the Kde-frameworks-devel mailing list