D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL
Adriaan de Groot
noreply at phabricator.kde.org
Thu Aug 22 11:02:42 BST 2019
adridg created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
adridg requested review of this revision.
REVISION SUMMARY
The existing macro always inherits from KPluginFactory -- making
it hard to use when sub-classing KPluginFactory in order to extend it.
The parameter `baseFactory` to the macro isn't used.
Use `baseFactory` as the base class for the plugin.
BUG #410851
TEST PLAN
This is a tough one. Who knows what kind of junk people have put
into baseFactory, since it's not used.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23338
AFFECTED FILES
src/lib/plugin/kpluginfactory.h
To: adridg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190822/d7f721c7/attachment.html>
More information about the Kde-frameworks-devel
mailing list