D22723: Fix RunnerManager::queryFinished()

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Aug 21 14:52:37 BST 2019


apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in runnermanager.cpp:360
> can you explain why we need this?

In checkTearDown we have the code that reacts to the job being done. If we don't set it to true we'll never be looking at whether all jobs are done because we'll exit early the function.

Note that so far it was only being set to true in single runner mode, so it was impossible it we'd ever emit queryFinished() otherwise.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190821/e4b49792/attachment.html>


More information about the Kde-frameworks-devel mailing list