D23313: improve code in Snore backend

[Kai Uwe Broulik]

broulik added a comment.


  I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better

INLINE COMMENTS

> notifybysnore.cpp:141
> +
> +void NotifyBySnore::notify(KNotification* notification, KNotifyConfig *config)
> +{

The previous coding style was correct, asterisk goes with the name, not the type.

> notifybysnore.cpp:162
> +
> +    const QString iconPath = m_iconDir.path() + QLatin1Char('/') +
> +                             QString::number(notification->id()) + QStringLiteral(".png");

Plus goes on a new line so you can see without horizontally scroling what operator is being used:

  foo = bar
      + baz

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23313

To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190821/ab878e67/attachment.html>