D23205: [KProcessList] Optimize KProcessList::processInfo

[Aleix Pol Gonzalez]

apol added a comment.


  patch looks good overall.

INLINE COMMENTS

> kprocesslist_unix.cpp:157
>      const QStringList procIds = procDir.entryList();
>      if (procIds.isEmpty())
>          return rc;

checking if it's empty is unnecessary.

> kprocesslist_unix.cpp:171
> +    KProcessInfo processInfo;
> +    getProcessInfo(QString(QLatin1String("%1")).arg(pid), processInfo);
> +    return processInfo;

Use QString::number()

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190818/8c7e0e42/attachment-0001.html>