D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

[Luigi Toscano]

ltoscano added a comment.


  I can't check now, but I think the case were "the deprecated variable is set, but the new one is not, then the old one is used" should be  considered.

INLINE COMMENTS

> KF5DocToolsMacros.cmake:236
> +    if (NOT KDE_INSTALL_MANDIR)
> +        set(KDE_INSTALL_MANDIR share/man)
>      endif()

I wonder if we should consider the deprecated variable as well. It's deprecated, but if it has been set, and the new one is not set, the old one should be probably used.

> KF5DocToolsMacros.cmake:239
> +    if (NOT KDE_INSTALL_DOCBUNDLEDIR)
> +        set(KDE_INSTALL_DOCBUNDLEDIR share/doc/HTML)
>      endif()

Aee above.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190817/d1f4057f/attachment-0001.html>