D17595: Upstream Dolphin's file rename dialog

Méven Car noreply at phabricator.kde.org
Sat Aug 17 10:13:31 BST 2019


meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in renamefiledialog.cpp:246
> I see you used the more complicated solution of keeping showEvent and testing for spontaneous. Any reason? It didn't work from the constructor?

After some testing using !spontaneous() here is pointless.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190817/22086d33/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list