D23194: Making FileJob behave consistently.

[Alexander Saoutkin]

feverfew added inline comments.

INLINE COMMENTS

> file.cpp:550
> +        // Make sure data gets to disk.
> +        if (mFile->flush())
> +            written(bytesWritten);

Flushing on every write IMO is a bit expensive, but I don't like the fact that close() can't report errors and so we have silent data loss. Maybe we should implement a flush method in FileJob. It only really makes sense for the file slave, for sftp/smb it will be a noop... Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190816/7a3a2b91/attachment.html>