D23208: Use CMake find_dependency in CMake config file instead of find_package
Daan De Meyer
noreply at phabricator.kde.org
Fri Aug 16 18:33:18 BST 2019
daandemeyer created this revision.
daandemeyer added a reviewer: Framework: Syntax Highlighting.
daandemeyer added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this revision.
REVISION SUMMARY
find_dependency is preferred in config files to correctly propagate the QUIET and REQUIRED parameters from the enclosing find_package call. See https://cmake.org/cmake/help/v3.0/module/CMakeFindDependencyMacro.html#module:CMakeFindDependencyMacro.
The macro does not support COMPONENTS before CMake 3.8 so I split the original find_package up into two find_dependency calls. I also removed the NO_MODULE parameter. This is consistent with how the rest of KDE uses find_dependency.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23208
AFFECTED FILES
KF5SyntaxHighlightingConfig.cmake.in
To: daandemeyer, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190816/38ccfb57/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list