D23194: Making FileJob behave consistently.

[Alexander Saoutkin]

feverfew added inline comments.

INLINE COMMENTS

> chinmoyr wrote in file.cpp:520
> A loop is required here. The docs don't really specify anything about reading data in one go.

Exactly. The docs weren't specific at all. smb/sftp would read once, and return the result. the file slave would read until size was reached (or EOD). I decided to just convert file's behaviour to what smb/sftp do and updated the docs accordingly, for ease of use (and so that if new slaves implement KIO::open() they'd know how to implement the functions. Of course, I could do the converse, and change smb/sftp to behave like the file slave when reading/writing, but I can leave that up to debate, if others want to chime in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190816/0e666bc0/attachment.html>