D23171: Avoid enabling kcrash if it's only included via a plugin
David Edmundson
noreply at phabricator.kde.org
Thu Aug 15 10:25:31 BST 2019
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If a Qt app happens to load our plasma-integration plugin it shouldn't
change how bug reporting works.
There's no point showing drkonqi if there's not an
appropriate KDE product.
Worse, our crash handling can interfere with that processes own signal
handling.
This patch is effectively a copy of
02b523bad09aab062355e46771889b0f3709692f <https://phabricator.kde.org/R263:02b523bad09aab062355e46771889b0f3709692f> in kxmlgui for enabling auto-
accelerators only if the lib is linked directly.
BUG: 401637
TEST PLAN
Changed the crashtest app in drkonqi to not directly link - didn't get drkonqi
Re-enabled linking. Got drkonqi
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23171
AFFECTED FILES
src/kcrash.cpp
To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190815/a97d63cd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list