D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Aleix Pol Gonzalez]

apol added a comment.


  There's several unrealated changes I'd discourage but the patch looks good overall. +1

INLINE COMMENTS

> icoutils_wrestool.cpp:78
>  
> -        if ( name.at(0) == '\'' )
> -            name = name.mid(1, name.size()-2);
> +        if (name.at(0) == QLatin1Char('\'')) {
> +            name = name.mid(1, name.length() - 2);

startsWith()

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23145

To: broulik, vonreth, pali, antlarr, bruns
Cc: apol, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190814/0a664826/attachment.html>