D23159: Prevent error() being emitted when purposefully reading 0 bytes
Alexander Saoutkin
noreply at phabricator.kde.org
Wed Aug 14 19:15:48 BST 2019
feverfew created this revision.
feverfew added reviewers: dfaure, fvogt, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.
REVISION SUMMARY
Currently when 0 is passed as a parameter, if the file to be read is non-empty both data and error signals
are emitted. This behaviour is incorrect, as there is no error. This patch makes sure that only data is
emitted.
TEST PLAN
The application I'm developing that hit this bug now no longer hits this issue.
REPOSITORY
R241 KIO
BRANCH
Read0Bug (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23159
AFFECTED FILES
src/ioslaves/file/file.cpp
To: feverfew, dfaure, fvogt, chinmoyr
Cc: kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190814/01aac2ab/attachment.html>
More information about the Kde-frameworks-devel
mailing list