D23116: Fix missing digit and pixel-perfect alignment of depth action icons

Noah Davis noreply at phabricator.kde.org
Tue Aug 13 06:43:02 BST 2019


ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Not having `id="current-color-scheme"` causes stylesheets to not work correctly.

INLINE COMMENTS

> depth16to8.svg:1
> -<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 22 22">
> -  <defs id="defs3051">
> -    <style type="text/css" id="current-color-scheme">
> -      .ColorScheme-Text {
> +<svg version="1.1" viewBox="0 0 22 22" xmlns="http://www.w3.org/2000/svg"><style type="text/css">.ColorScheme-Text {
>          color:#eff0f1;

style needs `id="current-color-scheme"`

> depth8to16.svg:1
> -<svg xmlns="http://www.w3.org/2000/svg" xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" viewBox="0 0 22 22">
> -  <defs id="defs3051">
> -    <style type="text/css" id="current-color-scheme">
> -      .ColorScheme-Text {
> +<svg version="1.1" viewBox="0 0 22 22" xmlns="http://www.w3.org/2000/svg"><style type="text/css">.ColorScheme-Text {
>          color:#eff0f1;

style needs `id="current-color-scheme"`

> depth16to8.svg:1
> -<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 22 22">
> -  <defs id="defs3051">
> -    <style type="text/css" id="current-color-scheme">
> -      .ColorScheme-Text {
> +<svg version="1.1" viewBox="0 0 22 22" xmlns="http://www.w3.org/2000/svg"><style type="text/css">.ColorScheme-Text {
>          color:#232629;

style needs `id="current-color-scheme"`

> depth8to16.svg:1
> -<svg xmlns="http://www.w3.org/2000/svg" xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" viewBox="0 0 22 22">
> -  <defs id="defs3051">
> -    <style type="text/css" id="current-color-scheme">
> -      .ColorScheme-Text {
> +<svg version="1.1" viewBox="0 0 22 22" xmlns="http://www.w3.org/2000/svg"><style type="text/css">.ColorScheme-Text {
>          color:#232629;

style needs `id="current-color-scheme"`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190813/54c121cf/attachment.html>


More information about the Kde-frameworks-devel mailing list