D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> dhaumann wrote in definition.h:339
> Please improve the API documentation and add, for instance:
> 
> - Only existing keywordLists() can be changed. For non-existent keyword lists, false is returned.
> - @see keywordList(), keywordLists()
> 
> What I am currently also missing is a section about highlight invalidation: Does one have to trigger a document rehighlight oneself, and if so, how?
> 
> My point is: Assume a doc is highlighted up to line 100. Now you add keywords to a list that are used in these 100 lines, i.e. the highlighting may change arbitrarily.
> 
> How is the KSyntaxHighlighting user supposed to trigger a rehighlight? Or should one only change keyword lists before highlighting any document?

I more thinking in variant, when the highlighting more dynamic, and is done more, that one time. For example, in Cantor, we rehighlight whole worksheet, when a new variable created in curresponding session. So, if you write "my_var = 3" in Python session (and run command cell with this command), "my_var" starts to highlight by Cantor as variable after that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190812/cb03e8f1/attachment.html>