D23092: KRun: remove KProcessRunner dependency on QtWidgets

David Faure noreply at phabricator.kde.org
Sun Aug 11 13:58:36 BST 2019


dfaure created this revision.
dfaure added reviewers: nicolasfella, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The messagebox has moved up to the user of the class, KRun,
  via a signal.
  
  The long term plan is to move KProcessRunner to KIOGui, so the future
  OpenUrlJob can use it, but KProcessRunner uses KWindowSystem which still
  depends on QtWidgets at the moment.

TEST PLAN
  wrote ~/.local/share/applications/appdoesnotexist.desktop
  with Exec=appdoesnotexist and MimeType=text/plain;
  Started dolphin, RMB on text file, Open With AppDoesNotExist, and the message
  box "Could not find the program 'appdoesnotexist'" showed up as expected.

REPOSITORY
  R241 KIO

BRANCH
  kprocessrunner

REVISION DETAIL
  https://phabricator.kde.org/D23092

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: dfaure, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190811/6f16fe31/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list