D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload
David Faure
noreply at phabricator.kde.org
Sun Aug 11 13:22:43 BST 2019
dfaure updated this revision to Diff 63530.
dfaure added a comment.
Add test for QWidget overload and fix crash
I found out a comment in KWindowSystem::setMainWindow which said this was necessary
(urgh, bad API), so doing the same here, after the unittest showed that windowHandle()
is indeed nullptr otherwise.
If this commit is OK, then KWindowSystem::setMainWindow() is the (only) other one
which will need similar treatment.
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23088?vs=63527&id=63530
BRANCH
2019_setNewStartupId
REVISION DETAIL
https://phabricator.kde.org/D23088
AFFECTED FILES
autotests/kstartupinfo_unittest.cpp
src/kstartupinfo.cpp
src/kstartupinfo.h
To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190811/89f7e61e/attachment.html>
More information about the Kde-frameworks-devel
mailing list