D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

Anthony Fieroni noreply at phabricator.kde.org
Thu Aug 8 06:31:14 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> app.cpp:76-81
> +    if (m_tr) {
> +        // Parent proccess yielded us a new batch while previous have not yet finished
> +        // This should not happen, but better play safe
> +        m_tr->commit();
> +        delete m_tr;
>      }

processNextFile should be called till m_ids ends, why it does not happen, probably that's why @bruns reject your patch

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23008

To: poboiko, #baloo, bruns, ngraham
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190808/6e7d73b3/attachment.html>


More information about the Kde-frameworks-devel mailing list