D22975: [GridDelegate] Don't select unselected item when clicking on any of its action buttons

Nathaniel Graham noreply at phabricator.kde.org
Tue Aug 6 19:11:59 BST 2019


ngraham created this revision.
ngraham added reviewers: broulik, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In 6258f33fce3af55f7cdd3b5487cd04d8e53c0b38 <https://phabricator.kde.org/R296:6258f33fce3af55f7cdd3b5487cd04d8e53c0b38>, I changed the delegate action button
  behavior to select an unselected item when any of its buttons were clicked. In
  retrospect, this was a mistake and causes various issues with items becoming selected
  when they shouldn't be.
  
  This patch reverts that part of the change to the prior behavior.
  
  BUG: 404536
  Fixed-IN: 5.62

TEST PLAN
  Preview an unselected LNF theme or splash screen and navigate away from the KCM; no
  "unsaved changes" dialog
  
  Click on the delete or show in folder button on an unselected wallpaper item; still works

REPOSITORY
  R296 KDeclarative

BRANCH
  fix-delegate-selection-on-action-trigger (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22975

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190806/7f9d4be7/attachment.html>


More information about the Kde-frameworks-devel mailing list