D22964: [ColorButton] Forward accepted signal from ColorDialog

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Aug 6 12:53:45 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to react to the user explicitly accepting the dialog and picking a color.
  While there is a `currentColor` vs `color` property on the `ColorDialog`, you can still end up with unexpected change signal emissions when the underlying model changes. This signal is only ever emitted when the `ColorDialog` is accepted.

TEST PLAN
  Clicked the button, chose a color, clicked OK, got `accepted` emitted with the picked `color`

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22964

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/ColorButton.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190806/7fa8f6d1/attachment.html>


More information about the Kde-frameworks-devel mailing list