D22698: Support passing target to ki18n_wrap_ui macro
Alex Merry
noreply at phabricator.kde.org
Mon Aug 5 20:44:36 BST 2019
alexmerry added a comment.
Since you tagged me in this, I'll say that (as a former maintainer of Extra-CMake-Modules as well as someone who still makes extensive use of CMake professionally despite not doing much KDE stuff these days) the change looks good (and following modern conventions) from a CMake perspective.
The rest of KI18N_WRAP_UI is less nice (from a modern CMake perspective), but as a minimal change to support a feature that helps write cleaner CMake code downstream, I think this is a good patch.
REVISION DETAIL
https://phabricator.kde.org/D22698
To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190805/8188ab99/attachment.html>
More information about the Kde-frameworks-devel
mailing list