D22946: Include API to generically implement --replace arguments

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Just some API style nitpicks while this was by-passing. Not dealt with KDBusService recently, so cannot really comment otherwise. QCoreApplication::processEvents() in the constructor though makes me feel uncomfortable, any chance to make this async?

INLINE COMMENTS

> kdbusservice.h:150
> +     * This is is meant to be used to implement the --replace argument on applications.
> +     */
> +    explicit KDBusService(StartupOptions options, bool replace, QObject *parent = nullptr);

@since missing

> kdbusservice.h:151
> +     */
> +    explicit KDBusService(StartupOptions options, bool replace, QObject *parent = nullptr);
> +

Please no "bool" type argument, this makes places calling harder to understand -> https://community.kde.org/Policies/Library_Code_Policy#Flags

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190805/f3013459/attachment.html>