D22936: [Text thumbnailer] Don't show text preview for .directory and .flatpakref files

Nathaniel Graham noreply at phabricator.kde.org
Mon Aug 5 00:42:10 BST 2019


ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The text thumbnailer currently excludes .directory files from receiving text file
  thumbnails, but does not do the same for .directory and .flatpakref files which are
  the same things (actually text files that don't look, feel, or behave like text files).
  
  This patch extends the same logic to those types of files as well, making them not
  receive text previews and instead show their base mimetype or icon (if defined in the
  file).
  
  BUG: 410561
  BUG: 400201
  FIXED-IN: 19.08.0

TEST PLAN
  F7161776: No text file previews.png <https://phabricator.kde.org/F7161776>

REPOSITORY
  R320 KIO Extras

BRANCH
  no-text-file-previews-for-directory-and-flatpakref-files (branched from Applications/19.08)

REVISION DETAIL
  https://phabricator.kde.org/D22936

AFFECTED FILES
  thumbnail/textcreator.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190804/bcca81f8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list