D22860: introduce FallbackTapHandler

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fallbacktaphandler.cpp:71
> +        m_mouseDownItem.clear();
> +        m_mouseDownPos = QPointF();
> +

You're clearing before doing the tap evaluation which uses this

> fallbacktaphandler.cpp:77
> +
> +        if (QPointF(m_mouseDownPos - me->windowPos()).manhattanLength() >= QGuiApplication::styleHints()->startDragDistance()) {
> +            emit tapped(&eventProxy);

I don't follow this line. Should it be < startDragDistance?

> fallbacktaphandler.h:49
> +    Q_OBJECT
> +    Q_PROPERTY(Qt::MouseButtons acceptedButtons MEMBER m_acceptedButtons NOTIFY acceptedButtonsChanged)
> +

We need to update

  setAcceptedMouseButtons(Qt::LeftButton);

when this changes

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22860

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190801/e63b1d9f/attachment.html>