D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Apr 30 03:17:05 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Binary files with .spx extension are detected as audio/speex as the type
  has no file magic. Taglib will crash when trying to extract properties
  from these files. ArcGIS datasets contain affected binary files.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

AFFECTED FILES
  autotests/samplefiles/misdetected/test_arcgis_geodata.spx
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190430/d666a63d/attachment.html>


More information about the Kde-frameworks-devel mailing list