D20913: [TagLibExtractor] Fix crash on invalid Speex files

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Apr 30 03:15:28 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  TagLib::Ogg::Speex::File::isValid() returns true even for invalid files,
  but tag() only returns a valid XiphComment when the file is valid.
  
  Other TagLib::Ogg::* classes properly clear the valid flag when
  encountering files.
  
  See https://github.com/taglib/taglib/issues/902
  
  BUG: 403902

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20913

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190430/f4281148/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list