[craft-blueprints-kde] kde/frameworks/tier3/knotifications: Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly.

Ben Cooksley null at kde.org
Sun Apr 28 10:00:50 BST 2019


Git commit aeaac2863f7383780197c667a6a961256af6b4f5 by Ben Cooksley.
Committed on 28/04/2019 at 09:00.
Pushed by bcooksley into branch 'master'.

Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly.
This is a Craft level patch, so the proper patch still needs to go into knotifications, but at the very least this should hopefully let us get the Binary Factory up and running again.

CCMAIL: faure at kde.org
CCMAIL: montel at kde.org
CCMAIL: kde-frameworks-devel at kde.org

A  +13   -0    kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
M  +1    -0    kde/frameworks/tier3/knotifications/knotifications.py

https://commits.kde.org/craft-blueprints-kde/aeaac2863f7383780197c667a6a961256af6b4f5

diff --git a/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch b/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
new file mode 100644
index 0000000..536ae92
--- /dev/null
+++ b/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
@@ -0,0 +1,13 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 9b2c70a..0cded49 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -98,7 +98,7 @@ remove_definitions(-DQT_NO_CAST_FROM_BYTEARRAY)
+ if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
+     ecm_install_po_files_as_qm(po)
+ endif()
+-add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00)
++#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00)
+ add_subdirectory(src)
+ if (BUILD_TESTING)
+     add_subdirectory(tests)
diff --git a/kde/frameworks/tier3/knotifications/knotifications.py b/kde/frameworks/tier3/knotifications/knotifications.py
index 1ca952a..9bb4411 100644
--- a/kde/frameworks/tier3/knotifications/knotifications.py
+++ b/kde/frameworks/tier3/knotifications/knotifications.py
@@ -4,6 +4,7 @@ import info
 class subinfo(info.infoclass):
     def setTargets(self):
         self.versionInfo.setDefaultValues()
+        self.patchToApply['5.57.0'] = [("disabled-deprecated-before.patch", 1)]
 
         self.description = "TODO"
 


More information about the Kde-frameworks-devel mailing list