D20766: Use appropriate background color for text previews

Christoph Feck noreply at phabricator.kde.org
Tue Apr 23 15:02:30 BST 2019


cfeck requested changes to this revision.
cfeck added a comment.


  Before we can support both dark and light themes we need to investigate the KSyntaxHighlighting issue found by Friedrich.
  
  Later we could request a light or dark theme depending on the lightness of the QPalette entry, but I would suggest to use View instead of Window, because window backgrounds are gray with some themes, while view backgrounds usually have more contrast (either darker or brighter than gray).

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190423/755c8e43/attachment.html>


More information about the Kde-frameworks-devel mailing list