D20766: Use appropriate background color for text previews

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 23 10:51:58 BST 2019


broulik added inline comments.

INLINE COMMENTS

> textcreator.cpp:140
>  
> -            QColor bgColor = QColor ( 245, 245, 245 ); // light-grey background
> -            m_pixmap.fill( bgColor );
> +            m_pixmap.fill( KColorScheme(QPalette::Active).background().color() );
>  

Can't you use `QPalette` instead of `KColorScheme`? The latter parses config files on disk and is somewhat heavy

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin
Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190423/3a9f2ecd/attachment.html>


More information about the Kde-frameworks-devel mailing list