D20758: kpackagetool: read kpackage-generic.desktop from qrc
David Faure
noreply at phabricator.kde.org
Mon Apr 22 22:17:42 BST 2019
dfaure created this revision.
dfaure added reviewers: sitter, apol.
dfaure requested review of this revision.
TEST PLAN
(to mimick CI) : make uninstall in kpackage and then
QT_LOGGING_RULES='*=true' XDG_DATA_DIRS=$KDEDIR/share /d/kde/build/5/frameworks/kpackage/bin/kpackagetool5 --appstream-metainfo . --appstream-metainfo-output /tmp/a.xml
For some reason kpackagetool5 creates a KPluginMetaData from
metadata.desktop in 3 different places of the code
(Package::setPath calls metadata() but then it deletes it!, metadata() again later, and PackageTool::showAppstreamInfo)
Before: Unknown property type for key "X-Plasma-MainScript" -> falling back to string
After: No more warning
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20758
AFFECTED FILES
src/kpackagetool/kpackagetool.cpp
To: dfaure, sitter, apol
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190422/90000ccb/attachment.html>
More information about the Kde-frameworks-devel
mailing list