D20697: Review IconBorder

loh tar noreply at phabricator.kde.org
Mon Apr 22 05:45:05 BST 2019


loh.tar updated this revision to Diff 56693.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Add margin to the edit area, but I'm not sure if it should be done here. I guess renderer should do it
  - Simplify "additional folding highlighting", there is now the slightly gradient gone, bad?
  - Rename backGroundColor->iconBarColor to fit orig name, but that name sounds to me as it's only for the icon area of the border
  
  F6786421: pic.png <https://phabricator.kde.org/F6786421>

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56644&id=56693

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190422/6dfcc42d/attachment.html>


More information about the Kde-frameworks-devel mailing list