D20693: Remove pixelated border

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Sat Apr 20 09:42:16 BST 2019


leinir created this revision.
leinir added reviewers: KNewStuff, ngraham, sitter.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to KNewStuff's dialogues as well. It was, however, never done quite right, and it's making our dialogues look all silly. So, we remove it for now, and if we still want it, we can reintroduce them in a more modern fashion.
  BUG:391108

TEST PLAN
  Open the details dialogue of any knewstuff listing
  Before patch: See pixelated (and weirdly positioned) pixelated border on all preview images
  After patch: See no pixelated border

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

AFFECTED FILES
  data/CMakeLists.txt
  data/thumb_frame.png
  src/ui/imagepreviewwidget.cpp
  src/ui/imagepreviewwidget_p.h

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190420/629df90c/attachment.html>


More information about the Kde-frameworks-devel mailing list