D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28
Méven Car
noreply at phabricator.kde.org
Sat Apr 20 08:51:38 BST 2019
meven added a comment.
In D20096#451170 <https://phabricator.kde.org/D20096#451170>, @dfaure wrote:
> This change also introduced regressions in two unittests: jobtest and kdirmodeltest. I'll let you look into those :-)
>
> https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/
> https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/projectroot/autotests/kiowidgets_kdirmodeltest/
>
> The first one is probably just an extra file in the dir (I know, bad isolation of the tests), the second one is more.... unexpected.
The tests failures are not regressions as they are happened before the merge : https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/72/testReport/ although on Qt 5.12.
Failures are:
FAIL! : KFileItemTest::testListProperties(two (text+html) files) Compared values are not the same
Actual (props.mimeGroup()): ""
Expected (expectedMimeGroup): "text"
Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.10/autotests/kfileitemtest.cpp(590)]
I don't reproduce locally.
FAIL! : KDirListerTest::testRenameItem() Compared values are not the same
Actual (entry.second.mimetype()): "application/xhtml+xml"
Expected (QString("text/html")) : "text/html"
Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.10/autotests/kdirlistertest.cpp(557)]
I didn't reproduce locally, but I could see some issue in the test.
Here is a fix proposal for this test : D20692 <https://phabricator.kde.org/D20692>
Is it possible to test it on jenkins before merging ?
So it seems to me as sporadic failures of slightly unconsistent tests.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20096
To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190420/b75b7d4e/attachment.html>
More information about the Kde-frameworks-devel
mailing list