D20655: Use generated DBus interface
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 18 10:04:39 BST 2019
broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Avoids introspection calls when creating the manager or devices.
Also drop codepath for old UPower, according to their git, the interface hasn't changed since 2015 (that's as far back as the history went, I didn't go any further) so I think it's safe to assume everyone uses an upower version that has this.
TEST PLAN
Unless that special "last non-systemd version" some distros use is older than this?
- Plugged in my mouse, showed up, plugged it out, disappeared
- I shall test with my laptop whether the battery property changes are detected properly
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D20655
AFFECTED FILES
src/solid/devices/backends/upower/CMakeLists.txt
src/solid/devices/backends/upower/dbus/org.freedesktop.UPower.Device.xml
src/solid/devices/backends/upower/dbus/org.freedesktop.UPower.xml
src/solid/devices/backends/upower/upowerdevice.cpp
src/solid/devices/backends/upower/upowerdevice.h
src/solid/devices/backends/upower/upowermanager.cpp
src/solid/devices/backends/upower/upowermanager.h
To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190418/bdff8b3c/attachment.html>
More information about the Kde-frameworks-devel
mailing list