D20643: Fix invalid memory write on malformed tar files

[Aleix Pol Gonzalez]

apol added a comment.


  +1 in general

INLINE COMMENTS

> ktar.cpp:241
>      size--;    // ignore trailing null
> +    if (size > std::numeric_limits<int>::max()) {
> +        qCWarning(KArchiveLog) << "Failed to allocate memory for longlink of size" << size;

It could make sense to say that it's because of the maximum size longling can have in a comment.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20643

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190417/7619245d/attachment.html>