D20619: [balooctl] Use new helper in json output

Nathaniel Graham noreply at phabricator.kde.org
Wed Apr 17 17:32:25 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> statuscommand.cpp:226
>  
> -  QJsonDocument json;
> -  json.setArray(filesInfo);
> -  QTextStream out(stdout);
> -  out << json.toJson(QJsonDocument::Indented);
> +    for (const auto& fileName : args) {
> +        const auto file = collectFileStatus(tr, cfg, fileName);

Do we have to use `auto` here and below?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20619

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190417/20285882/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list