D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Apr 16 14:02:28 BST 2019
kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3855b68daf14760ed71aa961f231172 <https://phabricator.kde.org/R242:cee9c928e3855b68daf14760ed71aa961f231172>
As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".
Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
fixairoxygenprogressbarheight
REVISION DETAIL
https://phabricator.kde.org/D20602
AFFECTED FILES
src/desktoptheme/air/widgets/bar_meter_horizontal.svg
src/desktoptheme/oxygen/widgets/bar_meter_horizontal.svg
To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190416/481c33f8/attachment.html>
More information about the Kde-frameworks-devel
mailing list