D20595: Implement set_window_geometry

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Apr 16 09:35:45 BST 2019


zzag added inline comments.

INLINE COMMENTS

> xdgshell_interface.h:283
> +     * @brief windowGeometry
> +     * The position of the window within the buffer
> +     *

s/position/geometry/

> xdgshell_stable_interface.cpp:524
> +    if (s->m_topLevel) {
> +        s->m_topLevel->d_func()->windowGeometry = QRect(windowRect);
> +        emit s->m_topLevel->windowGeometryChanged(windowRect);

The copy constructor is redundant (most likely a leftover I guess).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190416/3d1d03e0/attachment.html>


More information about the Kde-frameworks-devel mailing list