D20570: [FrameSvgItem] Respect smooth property

Marco Martin noreply at phabricator.kde.org
Mon Apr 15 11:42:59 BST 2019


mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> framesvgitem.cpp:95
>      {
> +        setFiltering(filtering);
>          m_lastParent->appendChildNode(this);

could have here
frameSvg->smooth() ? QSGTexture::Linear : QSGTexture::Nearest;

to make the patch smaller?

anyways, i'm fine with either.. this one calculates the sace only once so may be arguued to be better

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20570

To: broulik, #plasma, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190415/a76a6ca4/attachment.html>


More information about the Kde-frameworks-devel mailing list