D20530: Fix signed/unsigned warning after statx change

David Faure noreply at phabricator.kde.org
Sun Apr 14 11:00:39 BST 2019


dfaure created this revision.
dfaure added reviewers: meven, fvogt, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  file.cpp:947:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  
    } else if (n > 0 && static_cast<size_t>(n) != bufferSize) {
  
  Tricky because the type of bufferSize depends on which #if branch was taken.

TEST PLAN
  Compiles without warning now (apparently I don't have statx available)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20530

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: dfaure, meven, fvogt, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190414/299ce1d5/attachment.html>


More information about the Kde-frameworks-devel mailing list