D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

Sharaf Zaman noreply at phabricator.kde.org
Sat Apr 13 16:02:54 BST 2019


sh-zam created this revision.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-buildsystem.
sh-zam requested review of this revision.

REVISION SUMMARY
  Don't include same dependency twice, one which was found
  from `readelf` in `specifydependencies.cmake` and other in
  `ANDROID_EXTRA_LIBS`.
  
  Bug fix: find stl was dependent on the order in which libc++
  was added, now it is independent.

TEST PLAN
  - add the same dependency in ANDROID_EXTRA_LIBS

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20509

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake
  toolchain/specifydependencies.cmake

To: sh-zam
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190413/a242b1ed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list