D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

David Faure noreply at phabricator.kde.org
Sat Apr 13 14:43:00 BST 2019


dfaure created this revision.
dfaure added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  This isn't a tree model.
  QAbstractTableModel's hasChildren() is a bit stupid about asking the
  model, I'll fix that in Qt: https://codereview.qt-project.org/258965
  Still, this is more correct.
  
  Caught by QAbstractItemModelTester, but probably harmless with
  the view used here.

TEST PLAN
  not much yet, I'm debugging the assert that happens later on
  (bug 395181)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20506

AFFECTED FILES
  src/kcharselect_p.h

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190413/02b0f99b/attachment.html>


More information about the Kde-frameworks-devel mailing list