D20495: KateIconBorder: Fix folding popup width and height

loh tar noreply at phabricator.kde.org
Fri Apr 12 15:50:24 BST 2019


loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Now take the popup the whole width of the view instead of the half
  - The height computation is fixed to use all possible space left and allow slightly overpainting of the view bottom to cover all lines properly
  
  I hope the latter point cause no distaste.
  When other lines are still visible is that for me always confusing.
  There is a patch left which fix the not correct end of the folding range,
  where the closing brace is not covered. (No pic sorry)
  Works for the preview nicely but cause trouble while perform the fold,
  so need some more work/ideas...

TEST PLAN
  F6768794: pic.png <https://phabricator.kde.org/F6768794>

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20495

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190412/64d7fd72/attachment.html>


More information about the Kde-frameworks-devel mailing list