D20493: Introduce and use KArchiveDirectory::addEntryV2

Albert Astals Cid noreply at phabricator.kde.org
Fri Apr 12 14:38:56 BST 2019


aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  The original addEntry can delete the entry that is passed in, but we have no way to know
  about it, so when that happens if we try to use the entry afterwards it will crash
  
  This patch changes all the cases where addEntry was used and the entry passed to it is used later in the code

TEST PLAN
  Broken file doesn't crash anymore

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20493

AFFECTED FILES
  src/k7zip.cpp
  src/karchive.cpp
  src/karchivedirectory.h
  src/krcc.cpp
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190412/f5f72aad/attachment.html>


More information about the Kde-frameworks-devel mailing list